-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][proxy] Fix connection read timeout handling in Pulsar Proxy #20014
[fix][proxy] Fix connection read timeout handling in Pulsar Proxy #20014
Conversation
- The behavior of the custom ProxyReadTimeoutHandler is not defined in any way and based on the code will result in bad behavior and proxy connections being closed - Remove ProxyReadTimeoutHandler that was added as part of Zero copy support (apache#15678) - replace with a solution where readTimeoutHandler is remove from the pipeline
/pulsarbot rerun-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
+1
Test failure looks potentially related to the PR:
|
@michaeljmarshall It's most likely yet another flaky one since this PR contains only proxy changes. Broker tests don't use the proxy. |
Motivation
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete