[fix][doc] ConnectorDocGenerator support Java 9+ #20100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Apr 14, 2023
| required = false, | ||
| defaultValue = "", | ||
| help = "The SSL config for elastic search." | ||
| ) | ||
| private ElasticSearchSslConfig ssl = new ElasticSearchSslConfig(); |
There was a problem hiding this comment.
Nested configs should be supported to generate configs properly. But I'd like to postpone it to a follow-up. Printing an empty string doesn't hurt and no regression here.
tisonkun
changed the title
|
Merging... |
poorbarcode
pushed a commit
that referenced
this pull request
May 7, 2023
Signed-off-by: tison <wander4096@gmail.com> (cherry picked from commit b7eab94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 9 changes ThreadContextClassLoader and SystemClassLoader to AppClassLoader from URLClassLoader.
We should use
java.class.pathinstead to get the related URLs.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: