[fix][schema] Apply Schema for GenericJsonRecord if present #20104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
2 tasks
aymkhalil
reviewed
Apr 14, 2023
| super(schemaVersion, fields); | ||
| this.jn = jn; | ||
| if (schemaInfo == null) { |
There was a problem hiding this comment.
I wonder if we should just mark schemaInfo @nonnull - it seems GenericJsonRecord is only meant to be used with Schema (otherwise, we open the door for schema/java type mismatch).
|
The pr had no activity for 30 days, mark with Stale label. |
|
No longer work on this. The schema functionality doesn't have a good shape to work on. This PR is no more than another monkey patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #20092.
Motivation
See #20092
Modifications
Add
jackson-dataformat-avroand convert JSONNode with AvroSchema if configuredVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: