Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][test] Add integration test for ExtensibleLoadManager #20138

Merged
merged 2 commits into from
Jun 16, 2023
Merged

[improve][test] Add integration test for ExtensibleLoadManager #20138

merged 2 commits into from
Jun 16, 2023

Conversation

Demogorgon314
Copy link
Member

PIP: #16691

Motivation

Add integration test for new load manager

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Demogorgon314 Demogorgon314 requested a review from gaoran10 April 19, 2023 13:33
@Demogorgon314 Demogorgon314 self-assigned this Apr 19, 2023
@Demogorgon314 Demogorgon314 changed the title [improve][test] Add integration test for new load manager [improve][test] Add integration test for ExtensibleLoadManager Apr 19, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 19, 2023
heesung-sn
heesung-sn approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@heesung-sn heesung-sn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@Demogorgon314 Demogorgon314 requested a review from eolivelli June 7, 2023 14:52
@tisonkun tisonkun self-requested a review June 15, 2023 14:14
eolivelli
eolivelli approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great starting point

+1

tisonkun
tisonkun approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 62eccc7 into apache:master Jun 16, 2023
@Technoboy- Technoboy- added this to the 3.1.0 milestone Jul 3, 2023
Technoboy- pushed a commit that referenced this pull request Jul 3, 2023
@Demogorgon314 @Technoboy-
[improve][test] Add integration test for ExtensibleLoadManager (#20138)
e407c4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@tisonkun tisonkun tisonkun approved these changes

@heesung-sn heesung-sn heesung-sn approved these changes

@gaoran10 gaoran10 Awaiting requested review from gaoran10

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

@mattisonchao mattisonchao Awaiting requested review from mattisonchao

Assignees

@Demogorgon314 Demogorgon314

Labels
area/test cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.1
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Demogorgon314 @eolivelli @tisonkun @heesung-sn @Technoboy- @RobertIndie