[revert] "[fix][broker] Fix tenant admin authorization bug. (#20068)" #20143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
doc-not-needed
|
Thank you for your point, you are right! In #20068, I have only considered the default authorization provider, so it looks like the correct implementation. If the custom authorization provider didn't handle the |
nodece
approved these changes
Apr 19, 2023
|
After revert, the test cases modification should be added anyway. See #20151 |
This was referenced May 7, 2023
|
To avoid conflicts, I cherry-picked all three patches into branch |
poorbarcode
pushed a commit
that referenced
this pull request
May 7, 2023
…#20143) This reverts commit fc17c1d. ### Motivation In #20068 we changed the way that the `AuthorizationService` is implemented. I think this approach could have unintended consequences. Instead, I think we should change the `Consumer` and the `Producer` logic to call the correct `AuthorizationService` method. I propose an update to the `Consumer` and `Producer` logic here #20142. Given that our goal is to deprecate the `AuthorizationService` methods for `canProduce` and `canConsume`, I think we should not change their implementations. ### Modifications * Revert #20068 ### Verifying this change This change is trivial. It removes certain test changes that were only made to make the previous PR work. ### Documentation - [x] `doc-not-needed` ### Matching PR in forked repository PR in forked repository: Skipping PR as I ran tests locally. (cherry picked from commit 00dc7a0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fc17c1d.
Motivation
In #20068 we changed the way that the
AuthorizationServiceis implemented. I think this approach could have unintended consequences. Instead, I think we should change theConsumerand theProducerlogic to call the correctAuthorizationServicemethod. I propose an update to theConsumerandProducerlogic here #20142.Given that our goal is to deprecate the
AuthorizationServicemethods forcanProduceandcanConsume, I think we should not change their implementations.Modifications
Verifying this change
This change is trivial. It removes certain test changes that were only made to make the previous PR work.
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: Skipping PR as I ran tests locally.