Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][test] fix bug for testcase(PersistentTopicsTest#testExamineMessage) #20154

Merged
merged 1 commit into from
Apr 22, 2023
Merged

[fix][test] fix bug for testcase(PersistentTopicsTest#testExamineMessage) #20154

merged 1 commit into from
Apr 22, 2023

Conversation

StevenLuMT
Copy link
Member

Motivation

PersistentTopicsTest#testExamineMessage:
testcase's expect is fail,so running successfully is unexpect

Modifications

when running successfully is unexpect, so assert.fail

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: StevenLuMT#8

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 20, 2023
@AnonHxy
Copy link
Contributor

AnonHxy commented Apr 21, 2023

LGTM

@StevenLuMT
Copy link
Member Author

/pulsarbot run-failure-checks

tisonkun
tisonkun approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit c58da14 into apache:master Apr 22, 2023
@poorbarcode poorbarcode added this to the 3.1.0 milestone May 7, 2023
poorbarcode pushed a commit that referenced this pull request May 7, 2023
@StevenLuMT @poorbarcode
[fix][test] fix bug for testcase(PersistentTopicsTest#testExamineMess…
54382a8 
…age) (#20154)

Co-authored-by: lushiji <lushiji@didiglobal.com>
(cherry picked from commit c58da14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@lifepuzzlefun lifepuzzlefun lifepuzzlefun approved these changes

@AnonHxy AnonHxy AnonHxy approved these changes

Assignees

@StevenLuMT StevenLuMT

Labels
area/test cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.1
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@StevenLuMT @AnonHxy @lifepuzzlefun @tisonkun @RobertIndie @poorbarcode