Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][fn] Make python install dependencies from requirements.txt #20174

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

jiangpengcheng
Copy link
Contributor

Fixes #20173

Master Issue: #xyz

PIP: #xyz

Motivation

Python instance should install dependencies from requirements.txt

Modifications

Make python instance install dependencies from requirements.txt

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#12

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 24, 2023
@jiangpengcheng jiangpengcheng force-pushed the fix_python_requirement branch from ce71558 to 162e3ce Compare May 4, 2023 02:06
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Jun 12, 2023
@tisonkun tisonkun requested review from nlu90 and removed request for merlimat June 15, 2023 13:52
@Technoboy- Technoboy- added this to the 3.2.0 milestone Jul 31, 2023
@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@github-actions github-actions bot removed the Stale label Aug 9, 2023
@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@jiangpengcheng jiangpengcheng force-pushed the fix_python_requirement branch from 5fc7042 to bf183d1 Compare August 18, 2023 06:37
@jiangpengcheng jiangpengcheng force-pushed the fix_python_requirement branch from bf183d1 to cc1e773 Compare August 30, 2023 07:41
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Sep 30, 2023
@tisonkun
Copy link
Member

Meriging...

Thanks for your contribution!

@tisonkun tisonkun merged commit 187e0cf into apache:master Oct 18, 2023
43 of 45 checks passed
Technoboy- pushed a commit that referenced this pull request Aug 7, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 8, 2024
…che#20174)

Co-authored-by: tison <wander4096@gmail.com>
(cherry picked from commit e8f89cb)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 12, 2024
…che#20174)

Co-authored-by: tison <wander4096@gmail.com>
(cherry picked from commit e8f89cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Python instance doesn't install dependency from requirements.txt
5 participants