[fix][broker]Fix deadlock of metadata store #20189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
poorbarcode
requested review from
merlimat,
codelipenghui,
gaoran10 and
mattisonchao
github-actions
bot
added
doc-not-needed
poorbarcode
force-pushed
the
fix/dl_of_meta_stroe
branch
from
354ef5f to
05e27e0
Compare
poorbarcode
added
release/2.10.5
release/2.11.2
release/3.0.1
type/bug
poorbarcode
force-pushed
the
fix/dl_of_meta_stroe
branch
from
c66ebb5 to
a928f4a
Compare
|
@poorbarcode @Technoboy- is this related to #20130 changes and review comments in any way? |
Sorry, I didn't notice this PR before, but I sense that the two problems are very similar. This PR is not related to #20130. #20130 is used to solve the deadlock of the |
|
Now the current modification is problematic because the I will fix it tomorrow |
congbobo184
approved these changes
May 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #20189 +/- ##
=============================================
+ Coverage 37.61% 72.98% +35.37%
- Complexity 12589 31971 +19382
=============================================
Files 1691 1868 +177
Lines 129028 138604 +9576
Branches 14066 15240 +1174
=============================================
+ Hits 48530 101166 +52636
+ Misses 74183 29399 -44784
- Partials 6315 8039 +1724
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
reviewed
May 12, 2023
| /** | ||
| * @Deprecated This method is only used by test. call "isServiceUnitActiveAsync" is better. | ||
| */ | ||
| @Deprecated | ||
| public boolean isServiceUnitActive(TopicName topicName) { | ||
| try { |
There was a problem hiding this comment.
would it make sense to use something like isServiceUnitActiveAsync(topicName).get(conf.getMetadataStoreOperationTimeoutSeconds(), SECONDS);
There was a problem hiding this comment.
I think it is a good suggestion. Already edit this method to make the test that calls the method works better.
Could you take a look again?
poorbarcode
added a commit
that referenced
this pull request
May 18, 2023
Motivation: This task loadOrCreatePersistentTopic occupied the event thread of the ZK client so that other ZK tasks could not be finished anymore(Including the task itself), and it calls bundlesCache.synchronous().get(nsname) which is a blocking method. Modification: Since the method getBundle(topic) will eventually call the method bundlesCache.synchronous().get(nsname), use getBundleAsync(topic) instead of getBundle(topic) to avoid blocking the thread. (cherry picked from commit 4678c36)
4 tasks
lhotari
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 22, 2023
Motivation: This task loadOrCreatePersistentTopic occupied the event thread of the ZK client so that other ZK tasks could not be finished anymore(Including the task itself), and it calls bundlesCache.synchronous().get(nsname) which is a blocking method. Modification: Since the method getBundle(topic) will eventually call the method bundlesCache.synchronous().get(nsname), use getBundleAsync(topic) instead of getBundle(topic) to avoid blocking the thread. (cherry picked from commit 4678c36) (cherry picked from commit 8a1a4be)
Technoboy-
pushed a commit
that referenced
this pull request
May 24, 2023
Motivation: This task loadOrCreatePersistentTopic occupied the event thread of the ZK client so that other ZK tasks could not be finished anymore(Including the task itself), and it calls bundlesCache.synchronous().get(nsname) which is a blocking method. Modification: Since the method getBundle(topic) will eventually call the method bundlesCache.synchronous().get(nsname), use getBundleAsync(topic) instead of getBundle(topic) to avoid blocking the thread.
poorbarcode
added a commit
that referenced
this pull request
May 30, 2023
Motivation: This task loadOrCreatePersistentTopic occupied the event thread of the ZK client so that other ZK tasks could not be finished anymore(Including the task itself), and it calls bundlesCache.synchronous().get(nsname) which is a blocking method. Modification: Since the method getBundle(topic) will eventually call the method bundlesCache.synchronous().get(nsname), use getBundleAsync(topic) instead of getBundle(topic) to avoid blocking the thread. (cherry picked from commit 4678c36)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
loadOrCreatePersistentTopic[1]: it callsgetBundles(load policies from ZK)afterLockManagerImpl.lambda$acquireLock. This all runs on the threadmain-EventThread.It stuck at https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java#L233bundlesCache.synchronous().get(nsname)which is a blocking method.splitBundle[2]: remove old bundles and create news. It stuck at https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java#L1143 caused bymain-EventThreadis busy.lookup[3]: refresh policies and get metadata. It stuck at https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java#L383 caused bybundlesCacheis loading.Note:
To reproduce
2.11.x) using KOPPub & Sub.[1]Task: load or create topics
[2] Task: split bundle
[3] Task: lookup
Modifications
Since the method
getBundle(topic)will eventually call the methodbundlesCache.synchronous().get(nsname), usegetBundleAsync(topic)instead ofgetBundle(topic)to avoid blocking the thread.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: