[fix][test] Fix flaky test ConnectionPoolTest.testSetProxyToTargetBrokerAddress #20293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #20293 +/- ##
=============================================
+ Coverage 37.57% 72.93% +35.35%
- Complexity 12602 31961 +19359
=============================================
Files 1691 1868 +177
Lines 129033 138601 +9568
Branches 14068 15240 +1172
=============================================
+ Hits 48490 101089 +52599
+ Misses 74226 29469 -44757
- Partials 6317 8043 +1726
Flags with carried forward coverage won't be shown. Click here to find out more. |
michaeljmarshall
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20290
Motivation
The test ConnectionPoolTest.testSetProxyToTargetBrokerAddress is flaky
Modifications
Modify test so that it's not flaky. Use separate
broker1andbroker2since the connection pool doesn't contain handling for separating direct and proxied connections to a broker.The key in the connection pool is the "logical address" which is the target broker. It doesn't take the "physical address" into account.
Documentation
docdoc-requireddoc-not-neededdoc-complete