Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fix flaky test NonPersistentTopicTest.testMsgDropStat, 3rd attempt #20429

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 29, 2023

Fixes #20386

Motivation

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

…rd attempt

- underlying issue was IndexOutOfBoundsException which doesn't get retried
  by Awaitility unless `.ignoreExceptions()` has been called
@lhotari lhotari added this to the 3.1.0 milestone May 29, 2023
@lhotari lhotari self-assigned this May 29, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 29, 2023
@lhotari lhotari changed the title [fix][tests] Fix flaky test NonPersistentTopicTest.testMsgDropStat, 3rd attempt [fix][test] Fix flaky test NonPersistentTopicTest.testMsgDropStat, 3rd attempt May 29, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20429 (7334b4a) into master (b5ef09e) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20429      +/-   ##
============================================
- Coverage     72.92%   72.87%   -0.05%     
+ Complexity    31897    31865      -32     
============================================
  Files          1865     1865              
  Lines        138439   138439              
  Branches      15192    15192              
============================================
- Hits         100953   100888      -65     
- Misses        29474    29537      +63     
- Partials       8012     8014       +2     
Flag Coverage Δ
inttests 24.16% <ø> (+0.01%) ⬆️
systests 24.91% <ø> (+0.02%) ⬆️
unittests 72.16% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 56 files with indirect coverage changes

@tisonkun tisonkun merged commit a26cf3e into apache:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky-test: NonPersistentTopicTest.testMsgDropStat
3 participants