Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][build] add --no-cache-dir in dockerfile to disable the pip cache #20477

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Jun 2, 2023

Motivation

It's usually suggested to add --no-cache-dir in dockerfile because PIP cache is useless in image and we can also reduce the image size by disabling the cache.

Modifications

Add the --no-cache-dir in dockerfile pip3 command.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 2, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20477 (0bfb5e5) into master (5e6e6ce) will increase coverage by 0.00%.
The diff coverage is 53.48%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #20477   +/-   ##
=========================================
  Coverage     72.95%   72.96%           
- Complexity    31914    31920    +6     
=========================================
  Files          1867     1867           
  Lines        138485   138523   +38     
  Branches      15202    15204    +2     
=========================================
+ Hits         101037   101077   +40     
+ Misses        29438    29431    -7     
- Partials       8010     8015    +5     
Flag Coverage Δ
inttests 24.14% <0.00%> (+0.02%) ⬆️
systests 24.95% <2.32%> (-0.08%) ⬇️
unittests 72.25% <53.48%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bookkeeper/mledger/ManagedLedgerFactoryConfig.java 89.47% <ø> (-0.53%) ⬇️
...ar/broker/authorization/AuthorizationProvider.java 8.51% <0.00%> (-0.80%) ⬇️
...lsar/broker/loadbalance/impl/ThresholdShedder.java 82.53% <20.00%> (-1.34%) ⬇️
...ker/authorization/PulsarAuthorizationProvider.java 71.19% <61.29%> (-1.45%) ⬇️
...sar/broker/authorization/AuthorizationService.java 57.53% <100.00%> (+0.33%) ⬆️

... and 74 files with indirect coverage changes

@tisonkun tisonkun changed the title [improve][docker]: add --no-cache-dir in dockerfile to disable the pip cache [improve][build] add --no-cache-dir in dockerfile to disable the pip cache Jun 2, 2023
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit ca00a83 into apache:master Jun 2, 2023
@ericsyh ericsyh deleted the patch-1 branch June 14, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants