[improve][broker] Improve efficiency of checking message deletion #20490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change order of condition evaluation - checking markDeletePosition is fast - omit creation of PositionImpl instances in trimDeletedEntries
lhotari
added
type/cleanup
tisonkun
approved these changes
Jun 5, 2023
…eDeleted-efficiency
michaeljmarshall
approved these changes
Jun 5, 2023
lifepuzzlefun
approved these changes
Jun 6, 2023
|
Merging... Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently deleted messages are checked in the order that individual messages are checked first and then comparing the mark delete position after this. Since the check for the mark delete position is a simple check, it's more efficient to check that first.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete