-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][build] Upgrade Testcontainers to 1.18.3 & docker-java to 3.3.0 #20531
[improve][build] Upgrade Testcontainers to 1.18.3 & docker-java to 3.3.0 #20531
Conversation
…3.3.0 - keep the dependencies up-to-date
this replaced previous PR #20519 |
IIRC once we picked to a specific branch we remove the |
I think the release label is supposed to stay on the PR. |
That's how I've been doing it for a year and a half. |
@tisonkun That's not how we have been using labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…3.0 (apache#20531) (cherry picked from commit fe556ab) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
…3.0 (apache#20531) (cherry picked from commit fe556ab) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
…3.0 (apache#20531) (cherry picked from commit fe556ab) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Motivation
Modifications
Upgrade Testcontainers to 1.18.3 and docker-java to 3.3.0 .
docker-java version has to be kept in sync with Testcontainers version.
The correct version can be found in the testcontainers pom. For example for 1.18.3, one can find the docker-java version here: https://repo1.maven.org/maven2/org/testcontainers/testcontainers/1.18.3/testcontainers-1.18.3.pom
Documentation
doc
doc-required
doc-not-needed
doc-complete