Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][build] Upgrade Testcontainers to 1.18.3 & docker-java to 3.3.0 #20531

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 7, 2023

Motivation

  • keep the dependency up-to-date

Modifications

Upgrade Testcontainers to 1.18.3 and docker-java to 3.3.0 .
docker-java version has to be kept in sync with Testcontainers version.

The correct version can be found in the testcontainers pom. For example for 1.18.3, one can find the docker-java version here: https://repo1.maven.org/maven2/org/testcontainers/testcontainers/1.18.3/testcontainers-1.18.3.pom

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2023

this replaced previous PR #20519

@lhotari lhotari merged commit fe556ab into apache:master Jun 7, 2023
lhotari added a commit that referenced this pull request Jun 7, 2023
@tisonkun
Copy link
Member

tisonkun commented Jun 7, 2023

IIRC once we picked to a specific branch we remove the release/xxx label. But that can be argued to still mark which version is fixed.

cc @Technoboy- @RobertIndie

@michaeljmarshall
Copy link
Member

I think the release label is supposed to stay on the PR.

@michaeljmarshall
Copy link
Member

That's how I've been doing it for a year and a half.

@lhotari
Copy link
Member Author

lhotari commented Jun 8, 2023

IIRC once we picked to a specific branch we remove the release/xxx label. But that can be argued to still mark which version is fixed.

cc @Technoboy- @RobertIndie

@tisonkun That's not how we have been using labels.
We can always change the way. One of the problems is that the process isn't documented. I wrote 2 long emails on the dev list, but I guess nobody has been able to read those yet.
This is the thread: https://lists.apache.org/thread/69mwjso51kzkrv5xgdmw04d9wngbg8br

Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nodece added a commit to nodece/pulsar that referenced this pull request Mar 12, 2024
…3.0 (apache#20531)

(cherry picked from commit fe556ab)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece pushed a commit to nodece/pulsar that referenced this pull request Mar 12, 2024
…3.0 (apache#20531)

(cherry picked from commit fe556ab)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece pushed a commit to nodece/pulsar that referenced this pull request Mar 12, 2024
…3.0 (apache#20531)

(cherry picked from commit fe556ab)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants