Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup][test] CSContainer needs not to inherit from ZKContainer #20543

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[cleanup][test] CSContainer needs not to inherit from ZKContainer #20543

merged 1 commit into from
Jun 13, 2023

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Jun 8, 2023

Code cleanup so that we read code more smoothly ..

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@tisonkun
[cleanup][test] CSContainer needs not to inherit from ZKContainer
d2ec0a3 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from lhotari June 8, 2023 14:28
@tisonkun tisonkun self-assigned this Jun 8, 2023
@tisonkun tisonkun added this to the 3.1.0 milestone Jun 8, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 8, 2023
@tisonkun tisonkun requested a review from nodece June 9, 2023 14:24
@tisonkun
Copy link
Member Author

Thanks for your reviews! Merging...

@tisonkun tisonkun merged commit ab01b66 into apache:master Jun 13, 2023
@tisonkun tisonkun deleted the pay-back-debt branch June 13, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodece nodece nodece approved these changes

@lhotari lhotari Awaiting requested review from lhotari

Assignees

@tisonkun tisonkun

Labels
area/test doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tisonkun @nodece