Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][doc] Fix doc of admin cli create-subscription #20680

Merged
merged 1 commit into from
Jul 4, 2023
Merged

[fix][doc] Fix doc of admin cli create-subscription #20680

merged 1 commit into from
Jul 4, 2023

Conversation

zhanghaou
Copy link
Contributor

When use pulsar-admin to get help of topic's operations, we can get the output:
image

It's a bit confusing.

It seems the description of '-s' is copied from reset-cursor
image

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 29, 2023
@tisonkun tisonkun added this to the 3.1.0 milestone Jul 4, 2023
@zhanghaou zhanghaou closed this Jul 4, 2023
@zhanghaou zhanghaou reopened this Jul 4, 2023
@tisonkun
Copy link
Member

tisonkun commented Jul 4, 2023

Merging...

Thanks for your contribution @zhanghaou!

@tisonkun tisonkun merged commit d45c179 into apache:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

Assignees

@zhanghaou zhanghaou

Labels
area/cli doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zhanghaou @tisonkun @gaoran10 @RobertIndie @315157973