Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][misc] Stop logging full stacktrace when SecurityUtility.loadConscryptProvider() fails to find Conscrypt with unknown error #20705

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

JooHyukKim
Copy link
Contributor

Fixes #20702

Motivation

Currently, SecurityUtility.loadConscryptProvider() logs full stacktrace when it fails to find Conscrypt on classpath and the exception is none ofClassNotFoundException, UnsatisfiedLinkError.

Modifications

  • Modify logging to just the e.getCause() and e.getMessage() instead of the full exception.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/16

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 2, 2023
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece nodece added this to the 3.1.0 milestone Jul 3, 2023
@JooHyukKim
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

1 similar comment
@JooHyukKim
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

Merging #20705 (7249fe9) into master (c5237ea) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20705      +/-   ##
============================================
- Coverage     73.13%   73.12%   -0.02%     
+ Complexity    32101     3734   -28367     
============================================
  Files          1871     1871              
  Lines        138982   138983       +1     
  Branches      15283    15283              
============================================
- Hits         101651   101630      -21     
- Misses        29280    29304      +24     
+ Partials       8051     8049       -2     
Flag Coverage Δ
inttests 24.17% <0.00%> (-0.04%) ⬇️
systests 25.00% <0.00%> (-0.12%) ⬇️
unittests 72.40% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/apache/pulsar/common/util/SecurityUtility.java 81.25% <0.00%> (-0.37%) ⬇️

... and 82 files with indirect coverage changes

@nodece nodece merged commit 4d13bdb into apache:master Jul 4, 2023
@JooHyukKim JooHyukKim deleted the 20702 branch July 7, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] pulsar-shell throws massive conscrypt stacktrace for every command when TLS is enabled on arm64
4 participants