Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Add broker interceptor conf #20719

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

crossoverJie
Copy link
Member

@crossoverJie crossoverJie commented Jul 5, 2023

Motivation

Make the brokerInterceptors parameter active.
When using helm to update this configuration, it is unable to write to the broker.conf configuration file.

Modifications

add brokerInterceptors/brokerInterceptorsDirectory config.

Verifying this change

  • Make sure that the change passes the CI checks.

  • Dependencies (add or upgrade a dependency)

  • The public API

  • The schema

  • The default values of configurations

  • The threading model

  • The binary protocol

  • The REST endpoints

  • The admin CLI options

  • The metrics

  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 5, 2023
@crossoverJie crossoverJie changed the title add broker interceptor conf [improve][broker] Add broker interceptor conf Jul 5, 2023
@nodece
Copy link
Member

nodece commented Jul 20, 2023

Could you add disableBrokerInterceptors to the config file?

@crossoverJie
Copy link
Member Author

Could you add disableBrokerInterceptors to the config file?

Done.

@nodece nodece merged commit d5f97bf into apache:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants