Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][doc] Add language support flag for --cleanup-subscription #20836

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jiangpengcheng
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jul 19, 2023
@Anonymitaet
Copy link
Member

This PR adds docs for #20028

@Anonymitaet
Copy link
Member

@jiangpengcheng I've re-run the failed tests many times but still failed, can you ptal? (you can try git merge origin/master and then re-run tests)

@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

Merging #20836 (aa03b7c) into master (2ab184e) will decrease coverage by 0.42%.
Report is 16 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20836      +/-   ##
============================================
- Coverage     37.11%   36.69%   -0.42%     
- Complexity    12250    12478     +228     
============================================
  Files          1698     1698              
  Lines        129813   133553    +3740     
  Branches      14156    14653     +497     
============================================
+ Hits          48179    49008     +829     
- Misses        75318    78137    +2819     
- Partials       6316     6408      +92     
Flag Coverage Δ
inttests 24.16% <ø> (-0.23%) ⬇️
systests 25.10% <ø> (-0.30%) ⬇️
unittests 32.28% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...java/org/apache/pulsar/admin/cli/CmdFunctions.java 0.00% <ø> (ø)

... and 88 files with indirect coverage changes

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Sep 18, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. release/4.0.2 Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants