-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Inconsistent behaviour for topic auto_creation #20843
Merged
mattisonchao
merged 3 commits into
apache:master
from
mattisonchao:fix/auto_creation_inconsistent_behavior
Jul 21, 2023
Merged
[fix][broker] Inconsistent behaviour for topic auto_creation #20843
mattisonchao
merged 3 commits into
apache:master
from
mattisonchao:fix/auto_creation_inconsistent_behavior
Jul 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc-label-missing
doc-not-needed
Your PR changes do not impact docs
and removed
doc-label-missing
labels
Jul 20, 2023
mattisonchao
requested review from
eolivelli,
dlg99,
Technoboy-,
codelipenghui and
coderzc
and removed request for
eolivelli
July 20, 2023 10:03
Codecov Report
@@ Coverage Diff @@
## master #20843 +/- ##
============================================
+ Coverage 72.97% 73.09% +0.12%
- Complexity 32157 32176 +19
============================================
Files 1868 1868
Lines 139164 139185 +21
Branches 15314 15315 +1
============================================
+ Hits 101555 101742 +187
+ Misses 29562 29373 -189
- Partials 8047 8070 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
approved these changes
Jul 21, 2023
coderzc
approved these changes
Jul 21, 2023
Technoboy-
approved these changes
Jul 21, 2023
codelipenghui
approved these changes
Jul 21, 2023
This was referenced Jul 25, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.10
cherry-picked/branch-2.11
cherry-picked/branch-3.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.10.6
release/2.11.3
release/3.0.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Auto-creation topics
mechanism relies on namespace policies which are very important for the broker to determine if we should auto createpartitioned
topic ornon-partitioend
topic.We can't rely on the cache to get the random result. We should always load data from zk if the cache is missed to avoid fallback to broker default configuration.
e.g. If the metadata cache is missed, the logic will fallback to use broker configuration.
Broker configuration:
Namespace policies:
Modifications
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete