Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [broker] disable balancing based on DirectMemory. #21168

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[improve] [broker] disable balancing based on DirectMemory. #21168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fe420b
change default value of loadBalancerDirectMemoryResourceWeight.
thetumbled Sep 13, 2023
51b5413
fix checkstyle.
thetumbled Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion conf/broker.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,7 +1372,9 @@ loadBalancerCPUResourceWeight=1.0

# The direct memory usage weight when calculating new resource usage.
# It only takes effect in the ThresholdShedder strategy.
loadBalancerDirectMemoryResourceWeight=1.0
# Direct memory usage cannot accurately reflect the machine's load,
# and it is not recommended to use it to score the machine's load.
loadBalancerDirectMemoryResourceWeight=0

# Bundle unload minimum throughput threshold (MB), avoiding bundle unload frequently.
# It only takes effect in the ThresholdShedder strategy.
Expand Down
5 changes: 3 additions & 2 deletions pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,9 +2419,10 @@ The delayed message index time step(in seconds) in per bucket snapshot segment,
@FieldContext(
dynamic = true,
category = CATEGORY_LOAD_BALANCER,
doc = "Direct Memory Resource Usage Weight"
doc = "Direct Memory Resource Usage Weight. Direct memory usage cannot accurately reflect the "
+ "machine's load, and it is not recommended to use it to score the machine's load."
)
private double loadBalancerDirectMemoryResourceWeight = 1.0;
private double loadBalancerDirectMemoryResourceWeight = 0;

@FieldContext(
dynamic = true,
Expand Down