[improve][broker][PIP-286] Make the TopicCompactionService to support find entry based on publishTime or index #21208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
added
type/feature
coderzc
force-pushed
the
improve_pip_286
branch
from
2898e90 to
83edfc2
Compare
coderzc
requested review from
Technoboy-,
codelipenghui,
RobertIndie and
mattisonchao
coderzc
force-pushed
the
improve_pip_286
branch
from
83edfc2 to
8de7f06
Compare
|
|
||
| @Override | ||
| public CompletableFuture<Entry> findEntryByEntryIndex(long entryIndex) { | ||
| final Predicate<Entry> predicate = entry -> { |
There was a problem hiding this comment.
How do you handle if the entry index is minus value?
There was a problem hiding this comment.
It will return the first entry of compacted data, this is also consistent with the method definition, what do you think?
| @@ -106,6 +111,78 @@ public CompletableFuture<Position> getLastCompactedPosition() { | |||
| return CompletableFuture.completedFuture(compactedTopic.getCompactionHorizon().orElse(null)); | |||
| } | |||
|
|
|||
| @Override | |||
| public CompletableFuture<Entry> findEntryByPublishTime(long publishTime) { | |||
| final Predicate<Entry> predicate = entry -> { | |||
There was a problem hiding this comment.
How do you handle if the publishTime is minus value?
pulsar-broker/src/main/java/org/apache/pulsar/compaction/PulsarTopicCompactionService.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/compaction/PulsarTopicCompactionService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/compaction/PulsarTopicCompactionService.java
Outdated
Show resolved
Hide resolved
| CompletableFuture<Entry> findEntryByPublishTime(long publishTime); | ||
|
|
||
| /** | ||
| * Find the first entry that greater or equal to target entryIndex. |
There was a problem hiding this comment.
It requires the broker entry metadata. So we'd better improve the Javadoc to explain the behavior of broker entry metadata missed.
And please also add a test for this case.
There was a problem hiding this comment.
Ok. I changed the test to cover this case.
codelipenghui
approved these changes
Oct 18, 2023
|
/pulsarbot run-failure-checks |
RobertIndie
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #20867
Motivation
#20867
Modifications
Add
findEntryByPublishTimeandfindEntryByEntryIndexin the TopicCompactionService API.Implement them in the PulsarTopicCompactionService using binary search.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: