-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pip] PIP-322: Pulsar Rate Limiting Refactoring #21680
[improve][pip] PIP-322: Pulsar Rate Limiting Refactoring #21680
Conversation
da370b6
to
df62d05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is good to Pulsar functionality, and more important - to Pulsar developers and even users trying to figure out the code.
I read the background reading blog linked (from the section you mentioned), and the text in the PIP. I can honestly say I understand only 30% of how the solution would really look like, so without prior background it's hard for me personally to give proper feedback. I usually stay clear of reading PRs implementing PIP as they harder to read and take more time than PIPs :) so I try to make sure I can understand what I can from the PIP.
I truly appreciate how this overall addition to Pulsar raises the bar for Pulsar 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as PIP voted passed - https://lists.apache.org/thread/2s9hkmxovz1gop2031wk4v8skm270zh6
Thanks for driving this effort @lhotari!
Motivation
This contains PIP-322: Pulsar Rate Limiting Refactoring. Check the pip-322.md document for details.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete