[fix][broker] Fixed ServiceUnitStateChannel monitor to tombstone only inactive bundle states #21721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive bundle states
|
Looks good to me! |
Demogorgon314
approved these changes
Dec 14, 2023
merlimat
approved these changes
Dec 14, 2023
gaoran10
approved these changes
Dec 14, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21721 +/- ##
============================================
- Coverage 73.50% 73.38% -0.12%
+ Complexity 32818 32757 -61
============================================
Files 1893 1893
Lines 140721 140723 +2
Branches 15502 15503 +1
============================================
- Hits 103432 103270 -162
- Misses 29200 29345 +145
- Partials 8089 8108 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Jan 4, 2024
… inactive bundle states (apache#21721) (cherry picked from commit 8d16580)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 4, 2024
… inactive bundle states (apache#21721) (cherry picked from commit 8d16580) (cherry picked from commit 30fe564)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 8, 2024
… inactive bundle states (apache#21721) (cherry picked from commit 8d16580) (cherry picked from commit 30fe564)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a regression in the previous PR, https://github.com/apache/pulsar/pull/21213/files#r1425693449.
We should tombstone only inactive bundle states by the bundle state channel monitor thread. Currently, active bundle states(including the
Ownedstate) are tombstoned(cleaned), which incurs new bundle assignments.Modifications
Verifying this change
This change is already covered by existing tests. Please refer to the test changes in the PR.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: