-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix ResourceGroups loading #21781
Conversation
6ae4d30
to
d42e71d
Compare
/pulsarbot rerun-failure-checks |
...broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
Outdated
Show resolved
Hide resolved
/pulsarbot rerun-failure-checks |
2 similar comments
/pulsarbot rerun-failure-checks |
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21781 +/- ##
============================================
+ Coverage 73.57% 73.65% +0.08%
+ Complexity 32624 32197 -427
============================================
Files 1877 1887 +10
Lines 139502 139502
Branches 15299 15293 -6
============================================
+ Hits 102638 102754 +116
+ Misses 28908 28783 -125
- Partials 7956 7965 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListenerTest.java
Show resolved
Hide resolved
...er/src/test/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListenerTest.java
Outdated
Show resolved
Hide resolved
9d5b398
to
0bdfc31
Compare
#15126 has been closed, so this PR needs to be reviewed again. |
42edbb1
to
9ce029d
Compare
...broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
Outdated
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
Outdated
Show resolved
Hide resolved
9ce029d
to
e96b96a
Compare
e96b96a
to
68bb959
Compare
/pulsarbot rerun-failure-checks |
...broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
68bb959
to
42f2cb0
Compare
/pulsarbot rerun-failure-checks |
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 80b491d)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 80b491d)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 80b491d)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 80b491d)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 80b491d)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 80b491d)
Motivation
When the Pulsar starts up, the
ResourceGroupConfigListener.java
andResourceGroupNamespaceConfigListener.java
cache ResourceGroup and Namespace resources into memory for binding relationships. But this cache is loaded asynchronously, causing Namespace sometimes unable to find ResourceGroup.Modifications
Verifying this change
Added.
Documentation
doc
doc-required
doc-not-needed
doc-complete