[improve][ci] Run OWASP dependency check for offloaders and pulsar-io even when main check fails #21826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… even when main check fails
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #21826 +/- ##
=============================================
+ Coverage 36.38% 73.52% +37.13%
- Complexity 12299 32268 +19969
=============================================
Files 1722 1858 +136
Lines 131206 138132 +6926
Branches 14351 15139 +788
=============================================
+ Hits 47739 101559 +53820
+ Misses 77092 28702 -48390
- Partials 6375 7871 +1496
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tisonkun
approved these changes
Dec 29, 2023
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Jan 2, 2024
- Fix "Invalid workflow file" error - follow up for apache#21826 - GHA requires "if: ${{ !cancelled() }}"
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the OWASP dependency check won't run for distribution/offloaders and distribution/io (Pulsar IO connectors) when the main distribution's check fails. Example: https://github.com/apache/pulsar/actions/runs/7352401899/job/20017097977
Follow up for #21817.
Modifications
Add
if: !cancelled()to run the second step also when the first step fails. (GitHub Actions docs)Documentation
docdoc-requireddoc-not-neededdoc-complete