Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [broker] correct compaction phase one timeout meaning #21908

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[fix] [broker] correct compaction phase one timeout meaning #21908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1cebb1
fix doc.
thetumbled Jan 20, 2024
4f977ff
fix doc.
thetumbled Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conf/broker.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,8 +534,8 @@ brokerServiceCompactionMonitorIntervalInSeconds=60
# Using a value of 0, is disabling compression check.
brokerServiceCompactionThresholdInBytes=0

# Timeout for the compaction phase one loop.
# If the execution time of the compaction phase one loop exceeds this time, the compaction will not proceed.
# Timeout for each read request in the compaction phase one loop.
# If the execution time of one single message read operation exceeds this time, the compaction will not proceed.
brokerServiceCompactionPhaseOneLoopTimeInSeconds=30

# Whether retain null-key message during topic compaction
Expand Down
4 changes: 2 additions & 2 deletions pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2803,8 +2803,8 @@ The delayed message index time step(in seconds) in per bucket snapshot segment,

@FieldContext(
category = CATEGORY_SERVER,
doc = "Timeout for the compaction phase one loop, If the execution time of the compaction "
+ "phase one loop exceeds this time, the compaction will not proceed."
doc = "Timeout for each read request in the compaction phase one loop, If the execution time of one "
+ "single message read operation exceeds this time, the compaction will not proceed."
)
private long brokerServiceCompactionPhaseOneLoopTimeInSeconds = 30;

Expand Down
Loading