-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][admin] PIP-330: getMessagesById gets all messages #21918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
requested review from
Technoboy-,
codelipenghui,
RobertIndie,
BewareMyPower,
poorbarcode and
liudezhi2098
January 18, 2024 08:00
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21918 +/- ##
============================================
+ Coverage 73.53% 73.61% +0.07%
+ Complexity 32406 32404 -2
============================================
Files 1861 1861
Lines 138587 138588 +1
Branches 15185 15185
============================================
+ Hits 101916 102023 +107
+ Misses 28804 28680 -124
- Partials 7867 7885 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dao-jun
approved these changes
Jan 22, 2024
4 tasks
1 task
RobertIndie
added a commit
to apache/pulsar-client-go
that referenced
this pull request
Mar 8, 2024
### Motivation To keep consistent with the Java client. Releted PR: apache/pulsar#21918 ### Modifications Add `getMessagesById` interface. --------- Co-authored-by: Zike Yang <zike@apache.org>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 22f7323) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 22f7323) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #21873
Motivation
The
org.apache.pulsar.client.admin.Topics
providesgetMessageById(java.lang.String, long, long)
method to get themessage, which returns one message. If the message id refers to a batch message, we can only get the first message, not
all messages.
This behavior affects our analysis of messages by the message id.
Modifications
getMessagesById
andgetMessagesByIdAsync
methods to theorg.apache.pulsar.client.admin.Topics
interface.org.apache.pulsar.client.admin.internal.TopicsImpl
Verifying this change
The
testGetMessagesId
test has been added.Documentation
doc
doc-required
doc-not-needed
doc-complete