-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix getMessageById throws 500 #21919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
fix-get-messages-by-id-500
branch
from
January 18, 2024 11:12
7000cf4
to
3efd4a6
Compare
nodece
commented
Jan 18, 2024
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
Show resolved
Hide resolved
dao-jun
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/pulsarbot rerun-failure-checks |
Technoboy-
pushed a commit
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Technoboy-
pushed a commit
that referenced
this pull request
Jan 31, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Technoboy-
pushed a commit
that referenced
this pull request
Feb 5, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 6f7b9d9)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 6f7b9d9)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 55520bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.3
release/3.1.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using
bin/pulsar-admin topics get-message-by-id public/default/my-topic-1 -e 0 -l 1024
with a non-existent ledger, I expect to throw the 400 error instead of 500.CLI log:
Broker log:
Modifications
internalGetMessageById
, whenreadEntryFailed
returns LedgerNotExitException, convert this exception to 400 error.handle
recovery.Documentation
doc
doc-required
doc-not-needed
doc-complete