Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][misc] Upgrade Netty version to 4.1.105.Final #21923

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

Technoboy-
Copy link
Contributor

Motivation

Release note :
https://netty.io/news/2024/01/16/4-1-105-Final.html

Modifications

  • Upgrade Netty to 4.1.105.Final (from 4.1.104.Final)

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Jan 18, 2024
@Technoboy- Technoboy- added this to the 3.3.0 milestone Jan 18, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 18, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22838ea) 36.46% compared to head (9393ed5) 73.61%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21923       +/-   ##
=============================================
+ Coverage     36.46%   73.61%   +37.14%     
- Complexity    12390    32410    +20020     
=============================================
  Files          1725     1861      +136     
  Lines        131701   138593     +6892     
  Branches      14401    15185      +784     
=============================================
+ Hits          48027   102019    +53992     
+ Misses        77254    28684    -48570     
- Partials       6420     7890     +1470     
Flag Coverage Δ
inttests 24.13% <ø> (+0.02%) ⬆️
systests 23.65% <ø> (-0.02%) ⬇️
unittests 72.91% <ø> (+40.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1439 files with indirect coverage changes

Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Technoboy- Technoboy- merged commit 74f1cd5 into apache:master Jan 19, 2024
46 of 47 checks passed
lhotari pushed a commit that referenced this pull request Mar 27, 2024
lhotari pushed a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants