-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Restore the broker id to match the format used in existing Pulsar releases #21937
Merged
merlimat
merged 7 commits into
apache:master
from
lhotari:lh-revert-lookup-service-address-brokerId-port-change
Jan 21, 2024
Merged
[fix][broker] Restore the broker id to match the format used in existing Pulsar releases #21937
merlimat
merged 7 commits into
apache:master
from
lhotari:lh-revert-lookup-service-address-brokerId-port-change
Jan 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
the
release/blocker
Indicate the PR or issue that should block the release until it gets resolved
label
Jan 20, 2024
lhotari
changed the title
[fix][broker] Restore the broker id format used in existing Pulsar releases
[fix][broker] Restore the broker id to match the format used in existing Pulsar releases
Jan 20, 2024
Technoboy-
approved these changes
Jan 21, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #21937 +/- ##
============================================
- Coverage 73.76% 73.59% -0.17%
+ Complexity 32476 32411 -65
============================================
Files 1861 1861
Lines 138605 138677 +72
Branches 15186 15187 +1
============================================
- Hits 102238 102066 -172
- Misses 28505 28711 +206
- Partials 7862 7900 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
merlimat
approved these changes
Jan 21, 2024
Merged
4 tasks
15 tasks
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…ing Pulsar releases (apache#21937) (cherry picked from commit 6347315) (cherry picked from commit 89f722f)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…ing Pulsar releases (apache#21937) (cherry picked from commit 6347315) (cherry picked from commit 89f722f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/blocker
Indicate the PR or issue that should block the release until it gets resolved
release/3.0.3
release/3.1.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The "lookup service address" format was changed in PR #21015 based on an invalid issue report #21012.
"lookup service address" has been renamed to "brokerId" in #21894 to reduce confusion.
The value is not a service address to be used by any connections to the broker. It is used in the Pulsar load manager as
a unique runtime identifier for a broker instance.
It's better to not change the broker id format since there isn't a reason to do this. The format used in existing Pulsar releases should be restored and that's the motivation for this PR.
There was a misconception that PR #17136 would have changed the format in Pulsar 2.11 release. That PR didn't change the format. It can be verified from the diff.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete