-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [broker] Enable AppendBrokerTimestampMetadataInterceptor by default #21939
Conversation
[fix][test]Fix resource not close after method
@315157973 Please add the following content to your PR description and select a checkbox:
|
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But do we need a PIP to change the default config value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the issue already fixed by #21940, do we still need this PR?
Main Issue: #21347
Motivation
When the client machine's clock is incorrect (eg: set to 1 year later) and the Broker does not set the AppendBrokerTimestampMetadataInterceptor, the Ledger will not be cleaned up.
Because if the Broker's timestamp is not set, the expiration check will be based on the client's publish time.
As we discuss in https://lists.apache.org/thread/0vtjt436xvlg0fr4ogchkjdvjcp56mvz
Modifications
Enable
AppendBrokerTimestampMetadataInterceptor
by defaultVerifying this change
Does this pull request potentially affect one of the following parts:
The default values of configurations
doc-not-needed
Matching PR in forked repository
PR in forked repository: 315157973#13