[fix] Restored method as deprecated in AbstractMetadataStore #21950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
requested review from
lhotari,
Technoboy-,
codelipenghui and
poorbarcode
codelipenghui
approved these changes
Jan 23, 2024
|
We should also add annotations |
Technoboy-
approved these changes
Jan 23, 2024
nodece
reviewed
Jan 23, 2024
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Show resolved
Hide resolved
nodece
approved these changes
Jan 24, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #21950 +/- ##
=============================================
+ Coverage 36.46% 73.61% +37.15%
- Complexity 12390 32439 +20049
=============================================
Files 1725 1861 +136
Lines 131701 138676 +6975
Branches 14401 15182 +781
=============================================
+ Hits 48027 102093 +54066
+ Misses 77254 28700 -48554
- Partials 6420 7883 +1463
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
added a commit
that referenced
this pull request
Jan 27, 2024
Co-authored-by: Jiwe Guo <technoboy@apache.org>
|
Since #21068 does't cherry-pick to branch-3.1, so we remove the label |
lhotari
pushed a commit
that referenced
this pull request
Nov 28, 2024
Co-authored-by: Jiwe Guo <technoboy@apache.org> (cherry picked from commit 4198ed2)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 28, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A change in #21068 has renamed a protected methods in
AbstractMetadataStore. This was done in 3.1 and 3.2 as well as master branch.The problem with this change is that external metadata provider plugins cannot easily target 3.0/3.1 release because of the method name change. We shouldn't be renaming methods part of the plugin APIs. Instead we can mark them as deprecated and maintain compatibility.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: