[cleanup] [broker] fix doc for TransactionBuffer#isTxnAborted #21956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL, thanks. @congbobo184 @liangyepianzhou |
thetumbled
force-pushed
the
Fix_CodeClean
branch
from
e4d87ab to
2ca37d9
Compare
thetumbled
changed the title
liangyepianzhou
approved these changes
Jan 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21956 +/- ##
============================================
+ Coverage 73.60% 73.62% +0.01%
- Complexity 32411 32441 +30
============================================
Files 1861 1861
Lines 138674 138676 +2
Branches 15182 15184 +2
============================================
+ Hits 102070 102096 +26
+ Misses 28702 28696 -6
+ Partials 7902 7884 -18
Flags with carried forward coverage won't be shown. Click here to find out more. |
Technoboy-
reviewed
Jan 24, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/TransactionBuffer.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The argumentPositionImpl readPositionof methodorg.apache.pulsar.broker.transaction.buffer.TransactionBuffer#isTxnAbortedis weird and unneccessary, we have better remove it to avoid confusion.Argument
PositionImpl readPositionis used for future.Modifications
Remove the argumentPositionImpl readPosition.fix the doc and add to-do to avoid confusion.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: thetumbled#36