[fix] [broker] make rest api PersistentTopic#getLastMessageId consistent with binary api ServerCnx#handleGetLastMessageId #21967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21968
Motivation
The implementation of
org.apache.pulsar.broker.service.persistent.PersistentTopic#getLastMessageId
is not consistent withorg.apache.pulsar.broker.service.ServerCnx#handleGetLastMessageId
, for example,ServerCnx#handleGetLastMessageId
may get last message id from the compacted topic, whilePersistentTopic#getLastMessageId
don't.And flink-pulsar-connector also rely on the rest apiPersistentTopic#getLastMessageId
, we have better fix this problem.Older version of flink-pulsar-connector use it, latest version change to call
consumer.getLastMessageId();
.Modifications
Refactor
PersistentTopic#getLastMessageId
to be simillar withServerCnx#handleGetLastMessageId
.Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: thetumbled#37