[improve][broker] Include runtime dependencies in server distribution

[dragosvictor]

Motivation

The server distribution assembly does not currently include artifact runtime dependencies, pulling only the compile dependencies instead. While this has not impacted the customers, a class loading issue can always crop up. This is what happened while importing OpenTelemetry dependencies related to PIP-320. OpenTelemetry itself marks its many dependencies as runtime (see, for instance, https://mvnrepository.com/artifact/io.opentelemetry/opentelemetry-exporter-otlp/1.34.1). Including each of them manually in our POM is both tedious and error-prone.

Modifications

• Reverts the dependency scope for the server assembly to the default value, runtime.
• Manually excludes some of the libraries that would be needlessly pulled.
• Allows org.roaringbitmap-shims-0.9.44.jar to be included in the assembly.
• Removes assembly exclusion for lombok as it is not needed anymore.

Verifying this change

• Make sure that the change passes the CI checks.

This change is already covered by existing integration tests.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: dragosvictor#9

[asafm]

Perhaps we should double-check by making a diff between the included JARs in the before and after versions?

[merlimat]

This is actually done by the license checked script :) The list there needs to match the jars included

[dragosvictor]

Perhaps we should double-check by making a diff between the included JARs in the before and after versions?

@merlimat pointed out that the license check essentially achieves this already. For extra caution, here's the assembly lib/ diff between the master branch and the proposed changes:

145d144
< javax.annotation-javax.annotation-api-1.3.2.jar
296a296
> org.roaringbitmap-shims-0.9.44.jar