Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixed implicit conversions from long -> int #22055

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

merlimat
Copy link
Contributor

Motivation

Fix Implicit narrowing conversion in compound assignment issues reported by CodeQL scanner

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.3.0 milestone Feb 15, 2024
@merlimat merlimat self-assigned this Feb 15, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (beed0cf) 73.71% compared to head (850d308) 73.59%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22055      +/-   ##
============================================
- Coverage     73.71%   73.59%   -0.12%     
+ Complexity    32116    32074      -42     
============================================
  Files          1874     1874              
  Lines        139220   139220              
  Branches      15260    15260              
============================================
- Hits         102628   102465     -163     
- Misses        28695    28836     +141     
- Partials       7897     7919      +22     
Flag Coverage Δ
inttests 24.67% <6.25%> (-0.17%) ⬇️
systests 24.30% <6.25%> (-0.21%) ⬇️
unittests 72.87% <93.75%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...er/loadbalance/extensions/data/BrokerLoadData.java 99.25% <100.00%> (ø)
...e/extensions/filter/BrokerMaxTopicCountFilter.java 87.50% <100.00%> (ø)
...er/loadbalance/impl/PulsarResourceDescription.java 71.11% <100.00%> (ø)
...che/pulsar/broker/resourcegroup/ResourceGroup.java 83.05% <100.00%> (+1.01%) ⬆️
...sar/broker/resourcegroup/ResourceGroupService.java 73.56% <100.00%> (ø)
...rg/apache/pulsar/broker/service/BrokerService.java 81.07% <100.00%> (-0.06%) ⬇️
...va/org/apache/pulsar/broker/stats/BrokerStats.java 100.00% <ø> (ø)
...org/apache/pulsar/broker/stats/NamespaceStats.java 94.73% <ø> (ø)
.../pulsar/policies/data/loadbalancer/LoadReport.java 93.52% <ø> (ø)
...ar/policies/data/loadbalancer/LocalBrokerData.java 93.15% <ø> (ø)
... and 1 more

... and 74 files with indirect coverage changes

@lhotari lhotari merged commit fc2e314 into apache:master Feb 15, 2024
50 checks passed
@merlimat merlimat deleted the casting branch March 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants