-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][cli] Fix the bug when set-retention specified size with -T #22150
Conversation
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good work @Technoboy-
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22150 +/- ##
============================================
- Coverage 73.57% 73.54% -0.04%
+ Complexity 32624 32116 -508
============================================
Files 1877 1877
Lines 139502 139546 +44
Branches 15299 15312 +13
============================================
- Hits 102638 102627 -11
- Misses 28908 28954 +46
- Partials 7956 7965 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a similar bug in |
Fixes #22138
Motivation
When specified with -s with
-xT
, it will overflow when convert long to int.Documentation
doc
doc-required
doc-not-needed
doc-complete