[fix] [broker] print non log when delete partitioned topic failed

[poorbarcode]

Motivation

https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2968-L2983

replCloseFuture.thenCompose(v -> delete())
  .thenApply((res) -> tryToDeletePartitionedMetadata()) // This line lost the error throws by "tryToDeletePartitionedMetadata"
  .exceptionally(e -> {
    log.warn("[{}] Inactive topic deletion failed", topic, e);
   });
}

The line thenApply((res) -> tryToDeletePartitionedMetadata()) lost the error throws by "tryToDeletePartitionedMetadata", makes these two issues:

• No log was printed when deleting partitioned metadata failed.
• The future of delete the topic and delete partitioned topic metadata if needed only indicates delete topic partition, not delete topic and metadata. BTW, this future was not used anywhere.

Modifications

• Fix the issue
• Print an info level log if the partitioned metadata should not be deleted.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: x

[lhotari]

I think this impacts more than printing the log message. Switching from thenApply to thenComplete will also change when the resulting CompetableFuture completes?
If this is the case, please reflect this in the PR title and the description.

UPDATE: it seems that before, the log "Topic deleted successfully due to inactivity" could get printed before the operation had completed since thenApply was used.

[lhotari]

Good work @Technoboy-

[poorbarcode]

@lhotari

UPDATE: it seems that before, the log "Topic deleted successfully due to inactivity" could get printed before the operation had completed since thenApply was used.

Added this info into the Motivation, thanks

[poorbarcode]

Merging