Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [broker] Fix typo in CompactedTopicImpl. #22235

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Mar 10, 2024

Motivation

Fix typo problem.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete
  • The threading model

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 10, 2024
@thetumbled
Copy link
Member Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.56%. Comparing base (bbc6224) to head (bdf0c57).
Report is 36 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22235      +/-   ##
============================================
- Coverage     73.57%   73.56%   -0.02%     
+ Complexity    32624    32244     -380     
============================================
  Files          1877     1879       +2     
  Lines        139502   139787     +285     
  Branches      15299    15335      +36     
============================================
+ Hits         102638   102833     +195     
- Misses        28908    28958      +50     
- Partials       7956     7996      +40     
Flag Coverage Δ
inttests 26.80% <100.00%> (+2.21%) ⬆️
systests 24.34% <100.00%> (+0.01%) ⬆️
unittests 72.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...g/apache/pulsar/compaction/CompactedTopicImpl.java 62.42% <100.00%> (ø)

... and 77 files with indirect coverage changes

@mattisonchao mattisonchao requested a review from coderzc March 13, 2024 13:03
@Technoboy- Technoboy- merged commit 55625d9 into apache:master Mar 13, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants