Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ci] Tolerate mount option change failing in CI #22241

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Mar 11, 2024

Motivation

  • sometimes the mount option change fails in CI, causing unnecessary flakiness for CI builds.

Modifications

  • allow mount option change to fail, continue if that happens

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

- sometimes the mount option change fails in CI, tolerate that and continue
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 11, 2024
@Technoboy- Technoboy- added this to the 3.3.0 milestone Mar 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.62%. Comparing base (bbc6224) to head (93be640).
Report is 32 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22241      +/-   ##
============================================
+ Coverage     73.57%   73.62%   +0.04%     
+ Complexity    32624    32249     -375     
============================================
  Files          1877     1879       +2     
  Lines        139502   139793     +291     
  Branches      15299    15338      +39     
============================================
+ Hits         102638   102916     +278     
+ Misses        28908    28883      -25     
- Partials       7956     7994      +38     
Flag Coverage Δ
inttests 26.76% <ø> (+2.18%) ⬆️
systests 24.38% <ø> (+0.05%) ⬆️
unittests 72.87% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 76 files with indirect coverage changes

@lhotari lhotari merged commit 46a0226 into apache:master Mar 11, 2024
52 of 54 checks passed
lhotari added a commit that referenced this pull request Mar 15, 2024
lhotari added a commit that referenced this pull request Mar 15, 2024
lhotari added a commit that referenced this pull request Mar 15, 2024
lhotari added a commit that referenced this pull request Mar 15, 2024
lhotari added a commit that referenced this pull request Mar 15, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 3, 2024
(cherry picked from commit 46a0226)
(cherry picked from commit 1d05098)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 4, 2024
(cherry picked from commit 46a0226)
(cherry picked from commit 1d05098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants