Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][sec] Revert "[fix][sec] Add a check for the input time value (apache#22023)" #22243

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

liangyepianzhou
Copy link
Contributor

@liangyepianzhou liangyepianzhou commented Mar 11, 2024

Motivation

Fix #22242

Modifications

Revert "[fix][sec] Add a check for the input time value (#22023)"

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 11, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liangyepianzhou liangyepianzhou changed the title [fix][sec] Make -1 as a special value of lookupTimeout [fix][sec] Revert "[fix][sec] Add a check for the input time value (apache#22023)" Mar 11, 2024
@liangyepianzhou liangyepianzhou merged commit ffff639 into apache:master Mar 13, 2024
53 of 54 checks passed
lhotari pushed a commit that referenced this pull request Mar 13, 2024
@liangyepianzhou liangyepianzhou deleted the timeout branch March 14, 2024 06:49
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 3, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants