-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [broker] Support create RawReader based on configuration #22280
Merged
Technoboy-
merged 2 commits into
apache:master
from
hangc0276:chenhang/support_create_rawreader_based_on_configuration
Mar 18, 2024
Merged
[improve] [broker] Support create RawReader based on configuration #22280
Technoboy-
merged 2 commits into
apache:master
from
hangc0276:chenhang/support_create_rawreader_based_on_configuration
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
changed the title
Support create RawReader based on configuration
[improve] [broker] Support create RawReader based on configuration
Mar 15, 2024
hangc0276
requested review from
merlimat,
Technoboy-,
codelipenghui,
horizonzy,
zymap and
poorbarcode
March 15, 2024 16:19
hangc0276
added
release/3.2.2
category/functionality
Some functions are not working such as get errors
and removed
doc-not-needed
Your PR changes do not impact docs
labels
Mar 15, 2024
poorbarcode
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a test to confirm the config has been used.
@poorbarcode Added a unit test. |
zymap
approved these changes
Mar 18, 2024
horizonzy
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Technoboy-
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category/functionality
Some functions are not working such as get errors
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.2.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
When I use one Pulsar client to create multiple RawReaders to consume multiple topics, I need fine-grained control on the RawReader, such as changing the receiver queue size and enabling the AutoScaledReceiverQueueSize to control the Pulsar client memory usage to avoid direct memory OOM.
However, the current RawReader configuration is hard-coded and can't change anything.
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java
Lines 56 to 63 in 999e39b
We can provide more flexible control over RawReader creation.
Modifications
Provide a more flexible API to allow user to pass ConsumerConfigurationData to create RawReader.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: