Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][sec] Dismiss warning about MD5 since it's sufficient for these use cases #22282

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Mar 15, 2024

Motivation

  • CodeQL warns about using MD5 in 2 locations in the Pulsar code base

Modifications

  • Dismiss warning about MD5 since it's sufficient for these use cases

Additional context

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.3.0 milestone Mar 15, 2024
@lhotari lhotari self-assigned this Mar 15, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.64%. Comparing base (bbc6224) to head (75a112a).
Report is 58 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22282      +/-   ##
============================================
+ Coverage     73.57%   73.64%   +0.07%     
+ Complexity    32624    32256     -368     
============================================
  Files          1877     1887      +10     
  Lines        139502   139436      -66     
  Branches      15299    15292       -7     
============================================
+ Hits         102638   102691      +53     
+ Misses        28908    28787     -121     
- Partials       7956     7958       +2     
Flag Coverage Δ
inttests 26.87% <ø> (+2.29%) ⬆️
systests 24.44% <ø> (+0.12%) ⬆️
unittests 72.91% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...che/pulsar/client/impl/crypto/MessageCryptoBc.java 68.12% <ø> (ø)
...java/org/apache/pulsar/common/nar/NarUnpacker.java 80.32% <ø> (+1.63%) ⬆️

... and 102 files with indirect coverage changes

@lhotari lhotari merged commit 442595e into apache:master Mar 15, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants