Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][meta] Remove com.beust.jcommander.internal import #22294

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented Mar 18, 2024

Motivation

Do not use com.beust.jcommander.internal package.

Modifications

  • Use new ArrayList() instead of Lists.newArray()
  • Use new HastSet() instead of Sets.newHashSet()

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece nodece self-assigned this Mar 18, 2024
@nodece nodece added this to the 3.3.0 milestone Mar 18, 2024
@nodece nodece added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use ready-to-test labels Mar 18, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 18, 2024
@nodece
Copy link
Member Author

nodece commented Mar 19, 2024

pulsarbot rerun-failure-checks

@nodece
Copy link
Member Author

nodece commented Mar 19, 2024

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.66%. Comparing base (bbc6224) to head (d203098).
Report is 64 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22294      +/-   ##
============================================
+ Coverage     73.57%   73.66%   +0.09%     
- Complexity    32624    32744     +120     
============================================
  Files          1877     1887      +10     
  Lines        139502   139453      -49     
  Branches      15299    15293       -6     
============================================
+ Hits         102638   102731      +93     
+ Misses        28908    28761     -147     
- Partials       7956     7961       +5     
Flag Coverage Δ
inttests 26.92% <ø> (+2.33%) ⬆️
systests 24.68% <ø> (+0.35%) ⬆️
unittests 72.90% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 106 files with indirect coverage changes

@nodece nodece merged commit 8dc9a9b into apache:master Mar 19, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants