Derive direct memory used count from netty counter #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
force-pushed
the
direct_mem
branch
from
23084ad to
6f9d200
Compare
merlimat
reviewed
Feb 18, 2017
| private static Field directMemoryUsage = null; | ||
| static { | ||
| try { | ||
| directMemoryUsage = PlatformDependent.class.getDeclaredField("DIRECT_MEMORY_COUNTER"); |
There was a problem hiding this comment.
Since it's called a counter.. does it go down when the memory is released? :)
There was a problem hiding this comment.
yes, updated test-case with the release call.
rdhabalia
force-pushed
the
direct_mem
branch
from
6f9d200 to
8d0df29
Compare
|
Can we patch 1.16 as well? |
rdhabalia
force-pushed
the
direct_mem
branch
from
8d0df29 to
c4ce429
Compare
rdhabalia
added a commit
to rdhabalia/pulsar
that referenced
this pull request
Feb 21, 2017
* Derive direct memory used count from netty counter * Fix: avoid initial direct-memory assertion with 0
yes. |
rdhabalia
added a commit
that referenced
this pull request
Feb 21, 2017
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned at #222 :
JvmMetricsdoesn't return correct jvm_direct_memory_usedModifications
Get the directMemoryUsed count from Netty-
PlatformDependentcounter.Result
JvmMetricsprovides correct directMemoryUsed metric.