Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][cli] CmdConsume print publishTime And eventTime info. #22308

Merged

Conversation

chenhongSZ
Copy link
Contributor

@chenhongSZ chenhongSZ commented Mar 20, 2024

Motivation

CmdConsume print publishTime And eventTime info.

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 20, 2024
@Technoboy- Technoboy- added this to the 3.3.0 milestone Mar 20, 2024
@Technoboy- Technoboy- changed the title CmdConsume print publishTime And eventTime info. [improve][cli] CmdConsume print publishTime And eventTime info. Mar 20, 2024
@chenhongSZ
Copy link
Contributor Author

/pulsarbot run-failure-checks

@nodece
Copy link
Member

nodece commented Mar 20, 2024

/pulsarbot rerun-failure-checks

@dao-jun dao-jun closed this Mar 21, 2024
@dao-jun dao-jun reopened this Mar 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (bbc6224) to head (22807e1).
Report is 69 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22308      +/-   ##
============================================
- Coverage     73.57%   73.16%   -0.41%     
+ Complexity    32624    32252     -372     
============================================
  Files          1877     1887      +10     
  Lines        139502   140524    +1022     
  Branches      15299    15491     +192     
============================================
+ Hits         102638   102820     +182     
- Misses        28908    29740     +832     
- Partials       7956     7964       +8     
Flag Coverage Δ
inttests ?
systests 24.51% <0.00%> (+0.19%) ⬆️
unittests 72.51% <100.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...g/apache/pulsar/client/cli/AbstractCmdConsume.java 22.22% <100.00%> (+1.76%) ⬆️

... and 112 files with indirect coverage changes

@chenhongSZ
Copy link
Contributor Author

/pulsarbot run-failure-checks

@aloyszhang aloyszhang merged commit 74585b5 into apache:master Mar 21, 2024
50 checks passed
@chenhongSZ chenhongSZ deleted the CmdConsume-print-publishTimeAndEventTime branch March 26, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants