Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][cli] PIP-343: Use picocli instead of jcommander in pulsar-function #22331

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented Mar 22, 2024

PIP: #22181

Motivation

Improve CLI user experience.

Modifications

  • Use picocli instead of jcommander in pulsar-function

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece nodece self-assigned this Mar 22, 2024
@nodece nodece added this to the 3.3.0 milestone Mar 22, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 22, 2024
@nodece nodece force-pushed the pip-343-in-pulsar-function branch from 84d67b8 to 74bfa88 Compare March 22, 2024 13:38
@nodece
Copy link
Member Author

nodece commented Mar 23, 2024

/pulsarbot rerun-failure-checks

…unction

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece force-pushed the pip-343-in-pulsar-function branch from 74bfa88 to b39ab2b Compare March 25, 2024 04:07
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 73.72%. Comparing base (bbc6224) to head (b39ab2b).
Report is 79 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22331      +/-   ##
============================================
+ Coverage     73.57%   73.72%   +0.15%     
- Complexity    32624    32802     +178     
============================================
  Files          1877     1886       +9     
  Lines        139502   139415      -87     
  Branches      15299    15282      -17     
============================================
+ Hits         102638   102784     +146     
+ Misses        28908    28678     -230     
+ Partials       7956     7953       -3     
Flag Coverage Δ
inttests 26.97% <0.00%> (+2.38%) ⬆️
systests 24.48% <0.00%> (+0.15%) ⬆️
unittests 72.98% <9.09%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../java/org/apache/pulsar/functions/LocalRunner.java 50.82% <16.66%> (ø)
.../pulsar/functions/runtime/JavaInstanceStarter.java 0.00% <0.00%> (ø)

... and 136 files with indirect coverage changes

@nodece nodece merged commit 567174f into apache:master Mar 25, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants