[improve][io]: Add validation for JDBC sink not supporting primitive schema #22376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
approved these changes
Mar 28, 2024
RobertIndie
approved these changes
Mar 28, 2024
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 1, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Apr 3, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Apr 8, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…schema (apache#22376) (cherry picked from commit a503efc)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…schema (apache#22376) (cherry picked from commit a503efc)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…schema (apache#22376) (cherry picked from commit a503efc)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…schema (apache#22376) (cherry picked from commit a503efc)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…schema (apache#22376) (cherry picked from commit a503efc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently implemented for
JdbcAutoSchemaSinkconnector, It utilizesGenericRecord.getFieldto find fields with the same table column names.pulsar/pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/BaseJdbcAutoSchemaSink.java
Line 140 in 849cbf3
However, the return value of the primitive type schema is always null. This results in null data being inserted into the table, thereby causing errors.
Modifications
Verifying this change
testNotSupportPrimitiveSchemato cover it.Documentation
docdoc-requireddoc-not-neededdoc-complete