Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin][broker] Fix force delete subscription not working #22423

Merged
merged 5 commits into from
Apr 4, 2024
Merged

[admin][broker] Fix force delete subscription not working #22423

merged 5 commits into from
Apr 4, 2024

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Apr 4, 2024

Fixes #22404

Motivation

Fix force delete subscription not working on persistent topics.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dao-jun dao-jun self-assigned this Apr 4, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 4, 2024
@dao-jun dao-jun added this to the 3.3.0 milestone Apr 4, 2024
lhotari
lhotari approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dao-jun dao-jun merged commit ba8e8f5 into apache:master Apr 4, 2024
50 checks passed
@dao-jun dao-jun deleted the fix/force_delete_sub branch April 4, 2024 15:08
Technoboy- pushed a commit that referenced this pull request Apr 8, 2024
@dao-jun @Technoboy-
[admin][broker] Fix force delete subscription not working (#22423)
ed58028
Technoboy- pushed a commit that referenced this pull request Apr 8, 2024
@dao-jun @Technoboy-
[admin][broker] Fix force delete subscription not working (#22423)
110add0
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 15, 2024
@dao-jun @mukesh-ctds
[admin][broker] Fix force delete subscription not working (apache#22423)
9119643 
(cherry picked from commit 110add0)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
@dao-jun @mukesh-ctds
[admin][broker] Fix force delete subscription not working (apache#22423)
f10b2a0 
(cherry picked from commit 110add0)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
@dao-jun @mukesh-ctds
[admin][broker] Fix force delete subscription not working (apache#22423)
b8f4210 
(cherry picked from commit 110add0)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024
@dao-jun @mukesh-ctds
[admin][broker] Fix force delete subscription not working (apache#22423)
b2bee4a 
(cherry picked from commit 110add0)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
@dao-jun @srinath-ctds
[admin][broker] Fix force delete subscription not working (apache#22423)
a5b9be3 
(cherry picked from commit 110add0)
@fecet
Copy link

fecet commented Aug 3, 2024 •
edited
Loading

I still have the same issue with #22404 and #9477 on pulsar 3.3.1 on apachepulsar/pulsar-all:3.3.1

@fecet fecet mentioned this pull request Aug 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodece nodece nodece approved these changes

@lhotari lhotari lhotari approved these changes

@mattisonchao mattisonchao Awaiting requested review from mattisonchao

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

Assignees

@dao-jun dao-jun

Labels
area/admin cherry-picked/branch-3.0 cherry-picked/branch-3.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.5 release/3.2.3 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

[Bug] Force Delete subscription not working on persistent topics
5 participants
@dao-jun @fecet @lhotari @nodece @Technoboy-