Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][build] Upgrade Lombok to 1.18.32 for Java 22 support #22425

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Apr 4, 2024

Motivation

Java 22 has been released. Lombok 1.18.32 comes with Java 22 support.
Lombok changelog: https://projectlombok.org/changelog

Modifications

Upgrade Lombok to 1.18.32

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.3.0 milestone Apr 4, 2024
@lhotari lhotari self-assigned this Apr 4, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 4, 2024
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dao-jun dao-jun closed this Apr 4, 2024
@dao-jun dao-jun reopened this Apr 4, 2024
@lhotari
Copy link
Member Author

lhotari commented Apr 4, 2024

@dao-jun Please don't use closing and reopening PRs as a way to retry the build jobs.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.39%. Comparing base (bbc6224) to head (c7d12d2).
Report is 117 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22425      +/-   ##
============================================
- Coverage     73.57%   73.39%   -0.18%     
+ Complexity    32624    32418     -206     
============================================
  Files          1877     1873       -4     
  Lines        139502   139692     +190     
  Branches      15299    15308       +9     
============================================
- Hits         102638   102529     -109     
- Misses        28908    29222     +314     
+ Partials       7956     7941      -15     
Flag Coverage Δ
inttests 27.08% <ø> (+2.50%) ⬆️
systests ?
unittests 73.06% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 250 files with indirect coverage changes

@lhotari lhotari merged commit 5b6f91b into apache:master Apr 4, 2024
89 of 96 checks passed
lhotari added a commit that referenced this pull request Apr 22, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants